Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes for how to debug the network traffic #223

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Sep 29, 2022

Hoping this is fine to submit without a changelog entry given that it's just documentation. But let me know otherwise.

@github-actions
Copy link

github-actions bot commented Sep 29, 2022

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against 03ab3f2

@github-actions
Copy link

github-actions bot commented Sep 29, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/pcfM8h

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 36.46% // Head: 11.81% // Decreases project coverage by -24.65% ⚠️

Coverage data is based on head (a8caf23) compared to base (40d80e1).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head a8caf23 differs from pull request most recent head 03ab3f2. Consider uploading reports for the commit 03ab3f2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #223       +/-   ##
============================================
- Coverage    36.46%   11.81%   -24.66%     
============================================
  Files          213      213               
  Lines        14359    14358        -1     
  Branches      6992     6975       -17     
============================================
- Hits          5236     1696     -3540     
- Misses        8986    12619     +3633     
+ Partials       137       43       -94     
Impacted Files Coverage Δ
ElementX/Sources/Services/Room/RoomProxy.swift 0.00% <0.00%> (ø)
...entX/Sources/Services/Room/RoomProxyProtocol.swift 0.00% <ø> (ø)
...urces/Services/Timeline/RoomTimelineProvider.swift 0.00% <0.00%> (ø)
...urces/UserSession/UserSessionFlowCoordinator.swift 0.00% <0.00%> (ø)
ElementX/Sources/Other/Coordinator.swift 0.00% <0.00%> (-100.00%) ⬇️
DesignKit/Sources/Fonts/ElementFonts.swift 0.00% <0.00%> (-100.00%) ⬇️
DesignKit/Sources/Fonts/ElementBaseFonts.swift 0.00% <0.00%> (-100.00%) ⬇️
ElementX/Sources/UITests/UITestsRootView.swift 0.00% <0.00%> (-100.00%) ⬇️
...mentX/Sources/UITests/UITestScreenIdentifier.swift 0.00% <0.00%> (-100.00%) ⬇️
...tX/Sources/Other/ElementNavigationController.swift 0.00% <0.00%> (-100.00%) ⬇️
... and 97 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ismailgulek
Copy link
Contributor

Hoping this is fine to submit without a changelog entry given that it's just documentation. But let me know otherwise.

You can add one with doc extension i suppose. Details are at the changelog section. We could even copy that into here with some modifications.

@Johennes
Copy link
Contributor Author

Johennes commented Oct 5, 2022

Hoping this is fine to submit without a changelog entry given that it's just documentation. But let me know otherwise.

You can add one with doc extension i suppose. Details are at the changelog section. We could even copy that into here with some modifications.

Argh, I totally missed the doc extension. 🤦‍♂️ Have added a changelog file now.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stefanceriu stefanceriu enabled auto-merge (squash) October 14, 2022 12:57
@stefanceriu stefanceriu merged commit 27f6814 into develop Oct 14, 2022
@stefanceriu stefanceriu deleted the johannes/proxy branch October 14, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants